Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support self-closing tags in the parser #704

Closed
zml2008 opened this issue Feb 24, 2022 · 2 comments · Fixed by #707
Closed

Support self-closing tags in the parser #704

zml2008 opened this issue Feb 24, 2022 · 2 comments · Fixed by #707
Labels
area: text-minimessage type: enhancement
Milestone
4.10.0

Comments

@zml2008
Copy link
Member

zml2008 commented Feb 24, 2022

To be able to distinguish between components with no children and components who have all following content as a child, we should be able to have <tag/> be equivalent to <tag></tag> in the parser and serializer.

This would fully close #523.
@zml2008 zml2008 added this to the 4.11.0 milestone Feb 24, 2022
@kezz
Copy link
Member

kezz commented Feb 24, 2022

This would technically be a breaking change, right? So, <hi:Cool/> would be handled completely differently before/after this feature is implemented. Do we want to get it in before 4.10.0 or just have some way of handling it in the parser? Perhaps a warning that it will be handled differently in the future?

@zml2008
Copy link
Member Author

zml2008 commented Feb 24, 2022

ugh, I suppose - it's likely not that hard to implement so let's 4.10 this again

@zml2008 zml2008 modified the milestones: 4.11.0, 4.10.0 Feb 24, 2022
zml2008 added a commit that referenced this issue Feb 26, 2022
@zml2008
text-minimessage: Allow tags to be closed in one tag
46e2f61 
This simplifies the language for cases where certain tags have zero
children.

Fixes GH-704
Fixes GH-523
@rymiel rymiel linked a pull request Feb 26, 2022 that will close this issue
text-minimessage: Allow tags to be closed in one tag #707
Merged
zml2008 added a commit that referenced this issue Feb 27, 2022
@zml2008
text-minimessage: Allow tags to be closed in one tag
a111803 
This simplifies the language for cases where certain tags have zero
children.

Fixes GH-704
Fixes GH-523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: text-minimessage type: enhancement
Projects
None yet
Milestone
4.10.0
Development

Successfully merging a pull request may close this issue.

text-minimessage: Allow tags to be closed in one tag KyoriPowered/adventure
2 participants
@zml2008 @kezz