Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate non-API public stuffs with @ApiStatus.Internal #530

Closed
kezz opened this issue Sep 28, 2021 · 2 comments · Fixed by #712
Closed

Annotate non-API public stuffs with @ApiStatus.Internal #530

kezz opened this issue Sep 28, 2021 · 2 comments · Fixed by #712
Labels
area: text-minimessage
Milestone
4.10.0

Comments

@kezz
Copy link
Member

kezz commented Sep 28, 2021

No description provided.

@kashike kashike transferred this issue from KyoriPowered/adventure-text-minimessage Nov 28, 2021
@zml2008 zml2008 added this to the 4.10.0 milestone Dec 11, 2021
@zml2008
Copy link
Member

zml2008 commented Feb 7, 2022

Is this covered with the latest work in #672? That would leave the parser package as internal, and everything else that's not package-private as public API.

The tag implementation classes are currently still public, but that should be resolved as soon as serializer changes land.

@zml2008
Copy link
Member

zml2008 commented Feb 27, 2022

For whole packages that are internal, what do we think about moving them into a specific .internal package, to make it extra clear that they're not public API? That would also allow people to exclude them from auto-importing in their IDEs if the annotation doesn't do that already

zml2008 added a commit that referenced this issue Feb 28, 2022
@zml2008
text-minimessage: Move all internal classes to an internal package
226d5f2 
Hide the serializer SPI and internal classes from Javadoc.

Closes GH-530
@zml2008 zml2008 mentioned this issue Feb 28, 2022
Merged
zml2008 added a commit that referenced this issue Feb 28, 2022
@zml2008
text-minimessage: Move all internal classes to an internal package
8b70735 
Hide the serializer SPI and internal classes from Javadoc.

Closes GH-530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: text-minimessage
Projects
None yet
Milestone
4.10.0
Development

Successfully merging a pull request may close this issue.

text-minimessage: Move all internal classes to an internal package KyoriPowered/adventure
3 participants
@zml2008 @kezz @kashike