Begin updating for MM changes in adventure 4.10.0 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps a decent alternative would be to forward the debug output to the console, perhaps gated behind a off-by-default setting? |
|
Well, it doesn't take much to expose the tree view (KyoriPowered/adventure#658), but i admit it's not the most elegant solution. Hooking to the debug stuff might be more expressive |
rymiel
force-pushed
the
update/4.10.0
branch
from
5909f15 to
c3371fc
Compare
Since the minimessage parser now supports tags within string tags, it provides a superset of functionality compared to the system before, where there was a split between string and minimessage, which might have been confusing
rymiel
force-pushed
the
update/4.10.0
branch
from
c3371fc to
6f13aeb
Compare
|
Seems to be fully compatible with 4.10.0-SNAPSHOT currently, using KyoriPowered/adventure#658 for tree output |
kezz
force-pushed
the
update/4.10.0
branch
2 times, most recently
from
d4ecce0 to
b5160cd
Compare
kezz
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the webui interacts with things I'd consider to be implementation details within MM itself in order to get the tree, and so has not been modified for the removal of
Context.of.I believe MiniMessage will need to have some view of the parse tree exposed in order to fully update the webui for new changes.