Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CH-353] ShuffleSplitter improvement #354

Merged
merged 1 commit into from
Mar 21, 2023
Merged

[CH-353] ShuffleSplitter improvement #354

merged 1 commit into from
Mar 21, 2023

Conversation

exmy
Copy link

@exmy exmy commented Mar 9, 2023

Changelog category (leave one):

  • Improvement

see issue: issue-353

@kyligence-git
Copy link
Collaborator

Can one of the admins verify this patch?

@zzcclp zzcclp requested a review from liuneng1994 March 10, 2023 03:10
@exmy
Copy link
Author

exmy commented Mar 10, 2023

test this please with 1103

@liuneng1994
Copy link
Collaborator

test this please with 1103

liuneng1994
liuneng1994 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994
Copy link
Collaborator

test this please with 1103

@zzcclp zzcclp merged commit 9b896e0 into Kyligence:clickhouse_backend Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuneng1994 liuneng1994 liuneng1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@exmy @kyligence-git @liuneng1994 @zzcclp