Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read bytes to properly detect encoding #6

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: read bytes to properly detect encoding #6

merged 1 commit into from
Dec 4, 2024

Conversation

KyleKing
Copy link
Owner

@KyleKing KyleKing commented Dec 3, 2024

From: deanmalmgren#456

As of now, the txt parser reads files in text mode as UTF-8 and fails with other encodings. This makes it return a bytes object, leaving the base decode to figure out the encoding and act accordingly.

@LoicGrobol
Enable encoding detection for the txt parser
0123795 
As of now, the txt parser reads files in text mode as UTF-8 and fails with other encodings. This makes it return a bytes object, leaving the base `decode` to figure out the encoding and act accordingly.
@KyleKing KyleKing self-assigned this Dec 3, 2024
@KyleKing KyleKing changed the base branch from master to main December 3, 2024 13:33
@KyleKing KyleKing marked this pull request as ready for review December 4, 2024 11:04
@KyleKing KyleKing merged commit aa8eb5b into KyleKing:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KyleKing KyleKing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleKing @LoicGrobol