fix!: add expected newline #44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleKing
commented
Nov 22, 2024
| # A mapping from syntax tree node type to a function that renders it. | ||
| # This can be used to overwrite renderer functions of existing syntax | ||
| # or add support for new syntax. | ||
| RENDERERS: Mapping[str, Render] = { | ||
| "admonition_mkdocs": ADMON_RENDERS["admonition"], | ||
| # TODO: address conflict with mdformat-admon because mkdocs needs to override |
There was a problem hiding this comment.
Currently separating the shared utilities from mdformat-admon into a non-plugin utility package to avoid this conflict (https://github.com/KyleKing/mdformat-admonition-utils)
I also want to revisit the API and see if I can make a more composable version that doesn’t make so many assumptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses KyleKing/mdformat-admon#22 and that content tabs also include an extra newline https://squidfunk.github.io/mkdocs-material/reference/content-tabs/
There are some issues to address before merging. This will be a breaking change and needs to be versioned accordingly