fix: handle case when a pool is added liquidity in full range #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the pool is added liquidity in full range (from min tick to max tick), it will push the sqrtPriceLimitX96 to the extreme case, thus cause the swap function to return nil all the time
ghost
pushed a commit
that referenced
this pull request
Dec 28, 2022
* Support EncodeRouteToPath * Fix type error in selfpermit arguments, add test for selfpermit. * Fix the tick index mismatch in GetTick(daoleno#4) * Support SwapQuoter * Add custom input to MinimumAmountIn/Out * Upgrade sdk-core. Fix broken ether usage. * [WIP] SwapRouter * Applied core changes regarding currency abstraction (#8) * Applied core changes regarding currency abstraction * Updated core lib * add example code (#10) * upgrade go mod * Broken link in samples (#13) * Fixed broken link in samples * fix(trade): fix sortedInsert bug (#14) * test(swaprouter): SingleTradeInput & MultipleTradeInput unit test * test(swaprouter): trade with multiple routes unit test * feat(staker): uniswap v3 staker feature * optimize tick math (#19) * change module and add gitignore * Revert "refactor: avoid using panic (it crashes the API) (#5)" This reverts commit 47808c2. * Revert "fix: handle case when a pool is added liquidity in full range (#4)" This reverts commit 66e8ef2. * Revert "refactor: Improve searching for next tick (#3)" This reverts commit 54669aa. * Revert "refactor: Change package organization" This reverts commit 905a578. * Revert "refactor: Remove Unused Code" This reverts commit 3190335. * Revert "refactor: Rename Package" This reverts commit c249ea6. * Revert "fix: GetTick Function" This reverts commit f363610. Co-authored-by: daoleno <[email protected]> Co-authored-by: Vaulin Alexandr <[email protected]> Co-authored-by: 李亚夫 <[email protected]> Co-authored-by: Archil <[email protected]> Co-authored-by: xiang <[email protected]> Co-authored-by: Nathaniel Blakely <[email protected]> Co-authored-by: DoanNamTruc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the pool is added liquidity in full range (from min tick to max tick), it will push the sqrtPriceLimitX96 to the extreme case, thus cause the swap function to return nil all the time