Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data race with multiple goroutine #13

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix: data race with multiple goroutine #13

merged 2 commits into from
Sep 23, 2024

Conversation

hoanguyenkh
Copy link
Member

Why did we need it?

Related Issue

Release Note

How Has This Been Tested?

Screenshots (if appropriate):

@github-actions GitHub Actions
Copy link

Test coverage changes:

Package Before After Diff
github.com/KyberNetwork/kutils 98.60% 98.60% ✔️

@hoanguyenkh hoanguyenkh changed the title fix: data race when using klog fix: data race with multiple goroutine Sep 23, 2024
NgoKimPhu
NgoKimPhu approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@NgoKimPhu NgoKimPhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally Init is called once after the config is read, which should avoid this data race, but adding Once should also be fine

@hoanguyenkh hoanguyenkh merged commit 901d6db into main Sep 23, 2024
4 checks passed
@hoanguyenkh hoanguyenkh deleted the fix/data-race branch September 23, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NgoKimPhu NgoKimPhu NgoKimPhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoanguyenkh @NgoKimPhu