Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vault secret store impl #614

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Nov 23, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

add vault secret store impl

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Nov 23, 2023
@adohe adohe force-pushed the add_vault_secret_provider branch 2 times, most recently from d20c64f to fb40f59 Compare November 25, 2023 10:17
@adohe adohe changed the title WIP: add vault secret store impl feat: add vault secret store impl Nov 25, 2023
@coveralls
Copy link

coveralls commented Nov 27, 2023

Pull Request Test Coverage Report for Build 7004586438

  • 115 of 151 (76.16%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 75.226%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/secrets/providers/hashivault/vault.go 115 151 76.16%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/cmd/apply/options.go 7 71.83%
Totals Coverage Status
Change from base Build 7001360289: -0.1%
Covered Lines: 6580
Relevant Lines: 8747

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 0a5efbf into KusionStack:main Nov 28, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
@adohe adohe deleted the add_vault_secret_provider branch January 8, 2024 03:31
@ffforest ffforest linked an issue Jan 18, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: secret generator development
5 participants