Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add external secret store api and interface #610

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Nov 21, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

add external secret store api and interface

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added kind/feature Categorizes issue or PR as related to a new feature area/cli labels Nov 21, 2023
@coveralls
Copy link

coveralls commented Nov 21, 2023

Pull Request Test Coverage Report for Build 6952793517

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 75.779%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.61%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
Totals Coverage Status
Change from base Build 6952573998: -0.05%
Covered Lines: 6958
Relevant Lines: 9182

💛 - Coveralls

@adohe adohe force-pushed the add_base_secret_mng_interface branch from 4c0c635 to d9b1cf1 Compare November 22, 2023 04:15
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 2c7781c into KusionStack:main Nov 22, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
@adohe adohe deleted the add_base_secret_mng_interface branch January 8, 2024 03:31
@ffforest ffforest linked an issue Jan 18, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: secret generator development
5 participants