Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update workload generator support probe&lifecycle #495

Merged
merged 1 commit into from
Aug 28, 2023
Merged

feat: update workload generator support probe&lifecycle #495

merged 1 commit into from
Aug 28, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Aug 26, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

update workload generator support probe&lifecycle attributes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Aug 26, 2023
@adohe adohe added this to the 0.9.0 milestone Aug 26, 2023
@adohe adohe self-assigned this Aug 26, 2023
@adohe adohe requested review from howieyuen, SparkYuan and elliotxx and removed request for howieyuen August 26, 2023 13:12
@coveralls
Copy link

coveralls commented Aug 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5995264058

  • 153 of 190 (80.53%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 74.391%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/appconfiguration/generator/workload/workload_generator.go 127 164 77.44%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/cmd/apply/options.go 7 71.92%
Totals Coverage Status
Change from base Build 5973560751: 0.1%
Covered Lines: 5987
Relevant Lines: 8048
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 2d79171 into KusionStack:main Aug 28, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
@adohe adohe deleted the update_pod_generator branch August 29, 2023 04:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@elliotxx elliotxx Awaiting requested review from elliotxx

Assignees

@adohe adohe

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adohe @coveralls @SparkYuan