Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: refine "Build from Source" for README #36

Merged
merged 1 commit into from
May 18, 2022
Merged

docs: refine "Build from Source" for README #36

merged 1 commit into from
May 18, 2022

Conversation

elliotxx
Copy link
Contributor

Purpose:

  • refine "Build from Source" for README

@elliotxx elliotxx requested a review from amyXia1994 May 18, 2022 14:03
@coveralls
Copy link

coveralls commented May 18, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2346165240

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 77.073%
Files with Coverage Reduction New Missed Lines %
pkg/kusionctl/cmd/apply/options.go 7 83.75%
Totals Coverage Status
Change from base Build 2345676981: -0.1%
Covered Lines: 3755
Relevant Lines: 4872
💛 - Coveralls

amyXia1994
amyXia1994 reviewed May 18, 2022
View reviewed changes
README-zh.md Outdated Show resolved Hide resolved
@elliotxx elliotxx force-pushed the refine-build-from-source-in-readme branch from 71e8c38 to ad46749 Compare May 18, 2022 14:26
@elliotxx elliotxx requested a review from amyXia1994 May 18, 2022 14:34
@elliotxx elliotxx requested a review from Peefy May 18, 2022 14:58
Peefy
Peefy approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliotxx elliotxx merged commit ae0bfc4 into main May 18, 2022
@howieyuen howieyuen deleted the refine-build-from-source-in-readme branch May 19, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peefy Peefy Peefy approved these changes

@SparkYuan SparkYuan SparkYuan approved these changes

@howieyuen howieyuen Awaiting requested review from howieyuen

@markliby markliby Awaiting requested review from markliby

@amyXia1994 amyXia1994 Awaiting requested review from amyXia1994

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elliotxx @coveralls @SparkYuan @Peefy @amyXia1994