Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: kusion deps: ignore all paths in --ignore option even if they appear in focus paths #332

Merged
merged 1 commit into from
May 8, 2023

Conversation

amyXia1994
Copy link
Contributor

@amyXia1994 amyXia1994 commented Apr 26, 2023

What type of PR is this?

/kind update

What this PR does / why we need it:

Update: kusion deps: ignore all paths in --ignore option even if they appear in focus paths

Which issue(s) this PR fixes:

The old behavior of kusion deps was: for entrance file list of each stack/project, if they contains the file that should be ignored(passed through --ignore option), then that ignored entrance file will not be regarded as that stack/project's upstream dependency.

That behavior was designed to avoid hotspot dependence like https://github.com/KusionStack/konfig/blob/main/base/pkg/kusion_models/kube/render/render.k which will involve almost all the frontend/backend files to a stack/project's upstream dependency.

Now there are scenarios that require ignoring paths even if they appear in focus paths.

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 4808481565

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 71.921%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/deps/options.go 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/deps/options.go 6 81.36%
Totals Coverage Status
Change from base Build 4782325469: 0.03%
Covered Lines: 4777
Relevant Lines: 6642

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 1e29e8e into KusionStack:main May 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants