Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: ignore non-support TF resources #262

Merged
merged 1 commit into from
Mar 3, 2023
Merged

bugfix: ignore non-support TF resources #262

merged 1 commit into from
Mar 3, 2023

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Mar 1, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

TF resources not support watch, so ignore them, and not print details

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., design docs, usage docs, etc.:

@howieyuen howieyuen requested a review from liu-hm19 March 1, 2023 09:04
@howieyuen howieyuen added the kind/bug Something isn't working label Mar 1, 2023
@coveralls
Copy link

coveralls commented Mar 1, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4319965879

  • 14 of 19 (73.68%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 72.278%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/watch.go 14 19 73.68%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
Totals Coverage Status
Change from base Build 4312173935: -0.05%
Covered Lines: 4680
Relevant Lines: 6475
💛 - Coveralls

@howieyuen howieyuen changed the title bugfix: ignore non-support watch resources bugfix: ignore non-support TF resources Mar 1, 2023
@howieyuen howieyuen enabled auto-merge (squash) March 1, 2023 09:27
@howieyuen howieyuen force-pushed the watch-ui branch 2 times, most recently from 9fa9ef0 to cfc7898 Compare March 2, 2023 08:55
liu-hm19
liu-hm19 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 61f6f3d into KusionStack:main Mar 3, 2023
@howieyuen howieyuen deleted the watch-ui branch March 3, 2023 03:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howieyuen @coveralls @liu-hm19