Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor and cleanup the compile command #246

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind refactor
/kind cleanup

What this PR does / why we need it:

refactor and cleanup the compile command to make it more general and readable

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan enabled auto-merge (squash) February 14, 2023 09:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4172517639

  • 11 of 29 (37.93%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 72.116%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/kcl/kcl_generator.go 11 13 84.62%
pkg/cmd/compile/options.go 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/compile/options.go 1 34.62%
pkg/engine/operation/watch.go 1 88.28%
Totals Coverage Status
Change from base Build 4171617236: 0.05%
Covered Lines: 4676
Relevant Lines: 6484

💛 - Coveralls

@SparkYuan SparkYuan merged commit 9c39291 into KusionStack:main Feb 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
@SparkYuan SparkYuan deleted the refactor-kcl-generator branch June 26, 2023 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants