Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tf runtime workspace in stack dir #221

Merged

Conversation

markliby
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/runtime/terraform/terraform_runtime.go
pkg/engine/runtime/terraform/tfops/

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

The terraform runtime cache directory is in ~/.kusion/.terraform, which cannot support file reading in the stack directory. After the update, the terraform runtime working directory is in the stack directory, and the directory is stackdir/.{ID}

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@markliby markliby force-pushed the update_tf_runtime_workspace_in_stack branch from b346590 to bf3a931 Compare January 13, 2023 07:42
@coveralls
Copy link

coveralls commented Jan 13, 2023

Pull Request Test Coverage Report for Build 3937715495

  • 63 of 101 (62.38%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 72.139%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 37 41 90.24%
pkg/engine/runtime/terraform/terraform_runtime.go 26 60 43.33%
Files with Coverage Reduction New Missed Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 1 74.21%
pkg/engine/runtime/terraform/terraform_runtime.go 4 46.56%
Totals Coverage Status
Change from base Build 3926938443: 0.04%
Covered Lines: 4596
Relevant Lines: 6371

💛 - Coveralls

@markliby markliby force-pushed the update_tf_runtime_workspace_in_stack branch 2 times, most recently from 6af7182 to 5eb3ceb Compare January 17, 2023 08:18
@markliby markliby force-pushed the update_tf_runtime_workspace_in_stack branch from 5eb3ceb to d9faffd Compare January 17, 2023 09:07
@markliby markliby force-pushed the update_tf_runtime_workspace_in_stack branch from d9faffd to 6614da1 Compare January 17, 2023 09:13
@SparkYuan SparkYuan enabled auto-merge (squash) January 17, 2023 12:01
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 1f73d86 into KusionStack:main Jan 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants