Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init runtime with state #1288

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a bug of initializing Kusion's runtimes with release.State as input.

Which issue(s) this PR fixes:

Fixes #1287

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/bug Something isn't working label Sep 14, 2024
@liu-hm19 liu-hm19 added this to the v0.13.0 milestone Sep 14, 2024
@liu-hm19 liu-hm19 self-assigned this Sep 14, 2024
@coveralls
Copy link

coveralls commented Sep 14, 2024

Pull Request Test Coverage Report for Build 10916485217

Details

  • 4 of 7 (57.14%) changed or added relevant lines in 6 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 52.516%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/apply/apply.go 0 1 0.0%
pkg/engine/runtime/init/init.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/destroy.go 7 43.22%
Totals Coverage Status
Change from base Build 10807796261: -0.003%
Covered Lines: 9832
Relevant Lines: 18722

💛 - Coveralls

Copy link
Contributor

@Yangyang96 Yangyang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liu-hm19 liu-hm19 merged commit 750c700 into KusionStack:main Sep 19, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: kusion apply can't apply Kubernetes resources in some condition
3 participants