Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add KCL based customized health check #1268

Merged
merged 1 commit into from
Aug 21, 2024
Merged

feat: add KCL based customized health check #1268

merged 1 commit into from
Aug 21, 2024

Conversation

Yangyang96
Copy link
Contributor

@Yangyang96 Yangyang96 commented Aug 14, 2024 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1254

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Yangyang96 Yangyang96 changed the title Add KCL based customized health check feat: add KCL based customized health check Aug 14, 2024
@coveralls
Copy link

coveralls commented Aug 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10469561133

Details

  • 63 of 98 (64.29%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 52.794%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/apply/apply.go 20 28 71.43%
pkg/engine/printers/generate.go 9 17 52.94%
pkg/modules/generators/app_configurations_generator.go 2 11 18.18%
pkg/util/kcl/kcl.go 32 42 76.19%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 82.76%
Totals Coverage Status
Change from base Build 10446831805: 0.1%
Covered Lines: 9126
Relevant Lines: 17286
💛 - Coveralls

@Yangyang96
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Aug 19, 2024
@adohe adohe added this to the v0.13.0 milestone Aug 19, 2024
@Yangyang96 Yangyang96 force-pushed the feat_health branch 2 times, most recently from 7d3e180 to e26eb4e Compare August 19, 2024 03:01
liu-hm19
liu-hm19 reviewed Aug 19, 2024
View reviewed changes
pkg/cmd/apply/apply.go Outdated Show resolved Hide resolved
pkg/engine/printers/generate.go Show resolved Hide resolved
pkg/modules/generators/app_configurations_generator.go Outdated Show resolved Hide resolved
liu-hm19
liu-hm19 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 7566683 into KusionStack:main Aug 21, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

@ffforest ffforest ffforest left review comments

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

Assignees

@ffforest ffforest

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Feat: support of customized resource status check conditions for reconciliation
5 participants
@Yangyang96 @coveralls @ffforest @liu-hm19 @adohe