Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Viettel Cloud secrets manager #1267

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

hoangndst
Copy link
Collaborator

@hoangndst hoangndst commented Aug 13, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Integrate Viettel KMS with kusion to be able to use secrets at Viettel Cloud

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Aug 13, 2024

Pull Request Test Coverage Report for Build 10374610615

Details

  • 216 of 421 (51.31%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 52.515%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/secrets/providers/viettelcloud/secretsmanager/fake/fake.go 13 16 81.25%
pkg/workspace/validation.go 1 14 7.14%
pkg/secrets/providers/viettelcloud/secretsmanager/secretsmanager.go 56 86 65.12%
pkg/secrets/providers/viettelcloud/vclient/request.go 58 96 60.42%
pkg/secrets/providers/viettelcloud/vclient/response.go 42 100 42.0%
pkg/secrets/providers/viettelcloud/vclient/client.go 46 109 42.2%
Totals Coverage Status
Change from base Build 10302040287: -0.03%
Covered Lines: 8957
Relevant Lines: 17056

💛 - Coveralls

@SparkYuan
Copy link
Member

SparkYuan commented Aug 13, 2024

@hoangndst Please add more unit tests to improve the test coverage as it has decreased a lot. The test coverage of your PR should not decrease more than 0.3%

@hoangndst
Copy link
Collaborator Author

I have added unit tests to this PR.
cc @SparkYuan @liu-hm19

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit f2ee452 into KusionStack:main Aug 14, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants