Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support preview all details with flag #1233

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR implements the support for --all flag of kusion preview to directly showcase all of the diff details.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Jul 25, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jul 25, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan July 25, 2024 07:14
@liu-hm19 liu-hm19 self-assigned this Jul 25, 2024
@liu-hm19 liu-hm19 marked this pull request as ready for review July 25, 2024 07:14
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10089784781

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 54.124%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/preview/preview.go 8 12 66.67%
Totals Coverage Status
Change from base Build 9985449353: 0.07%
Covered Lines: 9404
Relevant Lines: 17375

💛 - Coveralls

@liu-hm19 liu-hm19 merged commit 86905a8 into KusionStack:main Jul 25, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants