Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support spec file as input of preview and apply #1185

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR supports the --spec-file flag in kusion preview and kusion apply.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Jun 25, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jun 25, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan June 25, 2024 09:17
@liu-hm19 liu-hm19 self-assigned this Jun 25, 2024
@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9659798441

Details

  • 11 of 60 (18.33%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 54.103%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/apply/apply.go 5 29 17.24%
pkg/cmd/preview/preview.go 6 31 19.35%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/apply.go 1 50.3%
pkg/cmd/preview/preview.go 2 39.57%
Totals Coverage Status
Change from base Build 9658530204: -0.1%
Covered Lines: 9124
Relevant Lines: 16864

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit a151828 into KusionStack:main Jun 27, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants