-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for on-premises secret provider define in api.kusion.io #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9639278902Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9640402778Details
💛 - Coveralls |
Liuxingyu1111111
changed the title
feat: add support for custom secret provider define in api.kusion.io
feat: add support for on-premises secret provider define in api.kusion.io
Jun 24, 2024
Pull Request Test Coverage Report for Build 9641914653Details
💛 - Coveralls |
SparkYuan
reviewed
Jun 24, 2024
Pull Request Test Coverage Report for Build 9642330685Details
💛 - Coveralls |
SparkYuan
reviewed
Jun 24, 2024
Pull Request Test Coverage Report for Build 9642898933Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9643022192Details
💛 - Coveralls |
SparkYuan
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Now if I want to add new secret provider in specific scene(some secret provider is only use in some company thus it can not be open source), I need to add new provider spec in apis/api.kusion.io/v1. I think apis/api.kusion.io/v1 should be consistent among different use case
Which issue(s) this PR fixes:
Fixes #1177
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: