Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for on-premises secret provider define in api.kusion.io #1179

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

Liuxingyu1111111
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Now if I want to add new secret provider in specific scene(some secret provider is only use in some company thus it can not be open source), I need to add new provider spec in apis/api.kusion.io/v1. I think apis/api.kusion.io/v1 should be consistent among different use case

Which issue(s) this PR fixes:

Fixes #1177

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9639278902

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 54.234%

Totals Coverage Status
Change from base Build 9610443685: 0.05%
Covered Lines: 9108
Relevant Lines: 16794

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9640402778

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 54.222%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 9610443685: 0.04%
Covered Lines: 9106
Relevant Lines: 16794

💛 - Coveralls

@Liuxingyu1111111 Liuxingyu1111111 changed the title feat: add support for custom secret provider define in api.kusion.io feat: add support for on-premises secret provider define in api.kusion.io Jun 24, 2024
@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9641914653

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 54.18%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/engine/api/destroy.go 7 83.06%
Totals Coverage Status
Change from base Build 9610443685: -0.004%
Covered Lines: 9099
Relevant Lines: 16794

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9642330685

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 54.225%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 9642175477: -0.01%
Covered Lines: 9112
Relevant Lines: 16804

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9642898933

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 54.237%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/secrets/providers.go 3 5 60.0%
Totals Coverage Status
Change from base Build 9642175477: 0.002%
Covered Lines: 9115
Relevant Lines: 16806

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9643022192

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 54.219%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/secrets/providers.go 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 9642175477: -0.02%
Covered Lines: 9112
Relevant Lines: 16806

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Liuxingyu1111111 Liuxingyu1111111 merged commit a3f2496 into KusionStack:main Jun 24, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants