Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip replacing secret data without ref prefix #1175

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a bug of replacing secret ref prefix in kusion apply command, which skips the secret data without ref prefix.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/bug Something isn't working label Jun 21, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jun 21, 2024
@liu-hm19 liu-hm19 self-assigned this Jun 21, 2024
Copy link
Contributor

@Liuxingyu1111111 Liuxingyu1111111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9610279912

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 54.208%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/graph/resource_node.go 0 4 0.0%
Totals Coverage Status
Change from base Build 9592837141: -0.01%
Covered Lines: 9102
Relevant Lines: 16791

💛 - Coveralls

@liu-hm19 liu-hm19 merged commit 1da8b5c into KusionStack:main Jun 21, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants