Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move secret references replacement form generating to applying #1173

Merged
merged 1 commit into from
Jun 20, 2024
Merged

feat: move secret references replacement form generating to applying #1173

merged 1 commit into from
Jun 20, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1171

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@SparkYuan SparkYuan force-pushed the secret branch 2 times, most recently from accb158 to d1a26ee Compare June 20, 2024 06:15
@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9592624480

Details

  • 51 of 101 (50.5%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 54.221%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/app_configurations_generator.go 1 3 33.33%
pkg/engine/operation/graph/resource_node.go 42 90 46.67%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/graph/resource_node.go 1 56.28%
Totals Coverage Status
Change from base Build 9562972244: -0.08%
Covered Lines: 9102
Relevant Lines: 16787
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 2241ae5 into KusionStack:main Jun 20, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: move secret references replacement form generating to applying
3 participants
@SparkYuan @coveralls @liu-hm19