Refactoring code for better readability #1395 #1458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's great having you contribute to this projectThank you for opening a Pull Request 🙌 , Welcome to Project Guidance 💖 We will review everything and get back to you :) |
|
@Gopal0Gupta Do mention the valid issue number. |
Kushal997-das
added
Hold
Gopal0Gupta
changed the title
Sorry, |
There was a problem hiding this comment.
Hello @Gopal0Gupta,
I've reviewed your code, and while it seems quite complex, I believe there are areas where it could be simplified. The old version appears to be much more straightforward.
Could you share your thoughts on this? I'm interested in understanding your approach and whether there are specific reasons for the complexity.
Kushal997-das
added
No_Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project-Guidance! 🎊🎈
Welcome! 🎉
Thank you for visiting our repository! We're excited to have you here. If you find this project useful, please consider giving it a star! ⭐
🎉 Have you reviewed the Contributing Guidelines? 🤔 (Required)
📝 Description
🔧 Fixes #1395 (Required)
🏷️ Initiative Participation (Required)
This pull request is associated with the following initiative. Please choose the one you are contributing to: