Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PagePart] (fix) skip checking for not persisted sub entites delete c… #3453

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mart-insiders
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets comma separated list of tickets fixed by the PR

Fixed a bug when persisting a pagepart with subentities where one is being deleted whilst not yet persisted. This causes the preg_match checks to not match and cause a 500 error. Later when iterating through the $subPagePartsToDelete, the $deleteInfo object is null and will also cause a 500 error.

@acrobat acrobat added this to the 7.2.0 milestone Nov 1, 2024
@acrobat acrobat merged commit 1d953e6 into Kunstmaan:7.x Nov 1, 2024
9 checks passed
@acrobat
Copy link
Member

acrobat commented Nov 1, 2024

Thanks @mart-insiders

@dannyvw dannyvw deleted the subenetities-persist-check branch November 2, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants