Fix: refactor plugin modals to dialogs to workaround J5.1 bug #9672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #9670 .
Summary of Changes
added new J5.1 dialogs when Joomla version is 5.1
Testing Instructions
test on both J5.1 and < J5.1
on J5.1 a dialog modal should open (save / save& close / close buttons on top
on < J5.1 a BS modal should open (buttons in the footer)
The J5.1 plugin dialog modal is missing the Toggle inline help button (the BS modal has that button in the footer).
I have crated a PR for that in the Joomla repository: appreciate if you could also test that and if okay report back as positive test result on the Joomla repository: joomla/joomla-cms#43296