Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: replace Joomla user filters with custom user filter in logs view #9651

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Ruud68
Copy link
Contributor

@Ruud68 Ruud68 commented Mar 11, 2024

Pull Request for Issue https://www.kunena.org/forum/k-6-3-0-support/168364-help-needed-logs-backend-view?start=0#230977 .

Summary of Changes

This PR replaces the two user filters (users / target users) in the logs view.
Currently the filters are based on the Joomla core users field, this PR changes these fields to a customized dropdown filter where only users are listed that have an entry in the logs table.

Testing Instructions

This is a proposal, I like the Joomla core users field, but the added value here is very limited and it doesn't allow us to overwrite the label (select user > select target user)

Let me know what you think so @xillibit can either decline or merge (after testing)

cc @rich20

@rich20
Copy link
Member

rich20 commented Mar 11, 2024

For me, the user filter is fine as it is. But I have found problem, so I will create a new ticket for it.

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 11, 2024

My preference is having the new filters as using the Joomla User fields can be confusing because they in label text do not differentiate between user and target user, further more the popup modal with all the filtering on the users is imo 'overkill'

@rich20
Copy link
Member

rich20 commented Mar 11, 2024

  • Succes

@xillibit xillibit added this to the 6.3 milestone Mar 11, 2024
@xillibit xillibit merged commit 04fa80c into Kunena:K6.3 Mar 11, 2024
4 checks passed
@Ruud68 Ruud68 deleted the user-logs-filter branch March 12, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants