Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored broken stats #9644

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Refactored broken stats #9644

merged 3 commits into from
Mar 5, 2024

Conversation

Ruud68
Copy link
Contributor

@Ruud68 Ruud68 commented Mar 5, 2024

Pull Request for Issue # .

Summary of Changes

Fixed the stats view
created a menu item for it (Forum Statistics)
added it as a tile in the cpanel (in the place of the statistics)

note: changed language files!

Testing Instructions

not much to test other then if it shows the correct forum statistics / user statistics

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 5, 2024

I think this is the final 'ListModel / View' back-end change for 6.3
next would be the FormModel / view refactoring, but that is also a lot of work and I think that this will be to muc for 6.3, so 6.4 maybe?

@xillibit xillibit added this to the 6.3 milestone Mar 5, 2024
@xillibit
Copy link
Member

xillibit commented Mar 5, 2024

For the big changes you can wait the branch K6.4, i will create this branch after the release of K6.3.x in stable.

@xillibit
Copy link
Member

xillibit commented Mar 5, 2024

Later in the day when the beta1 of Joomla! 5.1 will be released i will make the release of beta1 of K6.3. The branch K6.2 because is the last one to support Joomla! 4.4 needs to be maintened untill at last october 2024 because it's the end of bugfix

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 5, 2024

Did you test 6.3 on J4.4? To see if it works?
If there are any J5 specific changes in my PR's maybe I can rewrite them to be J4.4 compatible.

Do not currently have a J4 test site with Kunena on it (all my sites already migrated to J5)

@xillibit
Copy link
Member

xillibit commented Mar 5, 2024

Yes i had tested K6.3 on J!4.4 when you had started the refactoring to some view, there was an error about PopupButton class ,not found

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 5, 2024

Ok, if that is the only one I will do a PR this afternoon to replace that with J4 equivalent

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 5, 2024

@xillibit #9645

@xillibit
Copy link
Member

xillibit commented Mar 5, 2024

I will test in the evening your two PR now i don't have the means to test it

@xillibit
Copy link
Member

xillibit commented Mar 5, 2024

It's intended that you have the filters like it was :
image

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 5, 2024

That is the deprecated view statistics, that is removed from the menu. This is the &view=stats
it is set in the sidemenu and on the cpanel tile (Forum Statistics)

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 5, 2024

image

@xillibit
Copy link
Member

xillibit commented Mar 5, 2024

The menus aren't updated when i do a checkot i have couple of issues :
image

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 5, 2024

that's the old stats view, I think that there was an issues with the checkout files?

just did a quick check on the commited files in this PR and these are the correct / refactored ones. So must be an issue on your side

@xillibit
Copy link
Member

xillibit commented Mar 5, 2024

i have uninstalled Kunena and done a proprer install it's better now :
image

@xillibit xillibit merged commit e39d0b4 into Kunena:K6.3 Mar 5, 2024
4 checks passed
@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 5, 2024

That is the correct one

@Ruud68 Ruud68 deleted the stats-refactor branch March 6, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants