Fix: element (form) ID's must be unique on a page #9594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hi, this is not captcha related, that change I still need to do. First need to setup 6.3 Environment |
Thanks, yes I had noticed, that's why I labelled my post "off topic". |
xillibit
added a commit
that referenced
this pull request
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Potential Issue
Summary of Changes
elements on a page should have a unique ID, currently the quick reply forms all have the same form ID. This can cause errors / conflicts when trying to do CSS / JS functions on these forms
Testing Instructions
install PR, test if everything is still working.
Take special attantion when you have JS or CSS using the form ID "postform" as this ID now has been made unique with the message ID the postform is linked to.