Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various docs articles #5

Merged
merged 22 commits into from
Jan 15, 2023
Merged

Various docs articles #5

merged 22 commits into from
Jan 15, 2023

Conversation

tryoxiss
Copy link
Contributor

@tryoxiss tryoxiss commented Jan 7, 2023

No description provided.

@Kubulambula Kubulambula added the documentation Improvements or additions to documentation label Jan 7, 2023
Copy link
Owner

@Kubulambula Kubulambula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the suggested 'ls' and 'scn' commands are great, I don't want to indirectly promise anything by having it mentioned in the main branch docs.

You could open a new issue suggesting these commands and attaching a pull request with the ls and scn command docs and later we could add the commands themself.

Right now I want to focus on usability and polish, but if you implement the commands, I would be very happy.

I don't currently have much time because of finals, but I will soon return to work on GDShell and then I will make some new features

Anyway I really like your work and I very much appreciate it. The 'index' and 'man' pages are really good and if we document all the commands like this, that would be really awesome!

addons/gdshell/docs/en/commands/man.md Outdated Show resolved Hide resolved
addons/gdshell/docs/en/commands/man.md Outdated Show resolved Hide resolved
addons/gdshell/docs/en/commands/man.md Outdated Show resolved Hide resolved
addons/gdshell/docs/en/commands/index.md Outdated Show resolved Hide resolved
addons/gdshell/docs/en/commands/index.md Outdated Show resolved Hide resolved
addons/gdshell/docs/en/commands/index.md Outdated Show resolved Hide resolved
addons/gdshell/docs/en/commands/index.md Outdated Show resolved Hide resolved
addons/gdshell/docs/en/commands/index.md Outdated Show resolved Hide resolved
addons/gdshell/docs/en/commands/index.md Outdated Show resolved Hide resolved
@tryoxiss
Copy link
Contributor Author

I've made the chnages you've suggested, good to merge?

@Kubulambula
Copy link
Owner

Seems good to me. Thanks! ❤️

@Kubulambula Kubulambula merged commit 9ba0564 into Kubulambula:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants