Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework RHSSO into a more general OIDCProvider interface #74

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Aug 31, 2022

  • Introduce OIDCProvider interface
    • This enables us to quickly swap between OIDCProviders (planned Auth0 and RHSSO for now) without too much of a hassle
    • Add Token class which wraps the Token and can refresh itself if needed
    • Add oidc_provider fixture, which should replace rhsso_service_info almost everywhere
  • Cleanup of RHSSO interface
    • Remove unneeded methods
    • Remove RHSSOAdmin class
    • Move the initialization from fixture to RHSSOServiceConfiguration class
    • Move it into the new oidc module

Fix #68

@pehala pehala requested review from dhlavac and jakurban August 31, 2022 12:34
@pehala pehala force-pushed the rhsso_rewrite branch 2 times, most recently from 783c32a to 77fa8e9 Compare September 2, 2022 10:26
@pehala pehala requested a review from azgabur September 5, 2022 10:28
testsuite/oidc/rhsso/__init__.py Outdated Show resolved Hide resolved
testsuite/oidc/__init__.py Show resolved Hide resolved
@pehala pehala marked this pull request as ready for review September 7, 2022 08:53
@pehala pehala merged commit 128d96d into Kuadrant:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink RHSSO object structure
3 participants