FIX: ignoring has_kuadrant() check when --setup-plan option is used #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using --setup-plan to print out a "tesplan", `pytest_runtest_setup` uses `has_kuadrant()` check that might fail when oc client is not installed. Adding the condition when --setup-plan is used to skip any checks. fixes Kuadrant#618 Signed-off-by: Zdenek Kraus <[email protected]>
averevki
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using --setup-plan to print out a "tesplan",
pytest_runtest_setupuseshas_kuadrant()check will fail when kuadrant is not deployed, or oc has no access to any openshift. Which is not necessary when just listing tests.Adding the condition when --setup-plan is used to skip any checks.
fixes #618