Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default settings #533

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

averevki
Copy link
Contributor

Update default settings due to the introduced change in #516

Signed-off-by: averevki <[email protected]>
@averevki averevki added the enhancement Improvement to existing test label Sep 11, 2024
@averevki averevki self-assigned this Sep 11, 2024
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why not to add cluster2: {} as well?

Copy link
Contributor

@azgabur azgabur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add reasonable defaults for dns category as well

@averevki
Copy link
Contributor Author

Please add reasonable defaults for dns category as well

Only defaults I can set for DNS settings are public DNS servers, which would fail on the RH network we all use most of the time. There is an example with public servers in .tpl settings. I don't think we can set anything general for this test, let me know if you have something in mind

@azgabur
Copy link
Contributor

azgabur commented Sep 17, 2024

If geo tests will be skipped, then no default dns is needed
#537

@averevki averevki merged commit b52a86c into Kuadrant:main Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants