Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modify decorator #38

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Add modify decorator #38

merged 1 commit into from
Aug 8, 2022

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Aug 4, 2022

  • Add @modify decorator, which ensures the same methods can be used even if the object is already committed to the server.
    • Currently, the methods would modify the inner state of the object but wouldn't be propagated to the server. This enables them to modify their inner state before commitment and apply it even when it is already committed.
  • Create parent class for all our APIObjects

@pehala
Add modify decorator
24ec267 
- Create parent class for all our APIObjects
@pehala pehala requested review from jsmolar and azgabur August 4, 2022 13:35
@pehala pehala mentioned this pull request Aug 4, 2022
Merged
@pehala pehala requested a review from mdujava August 8, 2022 07:26
@pehala pehala merged commit 856fc41 into Kuadrant:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmolar jsmolar jsmolar approved these changes

@azgabur azgabur Awaiting requested review from azgabur

@mdujava mdujava Awaiting requested review from mdujava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pehala @jsmolar