Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS support #19

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Add TLS support #19

merged 3 commits into from
Aug 8, 2022

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Jul 11, 2022 •
edited
Loading

Main changes

  • Add classes for working with Certificates and CFSSL
    • CFSSL is a library developed by Cloudflare to make generating certificates easy (much easier than with regular OpenSSL)
  • Add test for Authorino with TLS
    • Tests that Authorino and Envoy can be configured with TLS and that they work

Side changes

  • Update README.md to reflect changes
    • Fix wrong minimum python version, there should have always been a 3.9
  • Add new template for Envoy with TLS
  • Ignore too-many-arguments warnings
    • Useless warning
  • Change scope fo Authorino fixture to module
    • Any module can now make changes to the configuration

Closes #7

@pehala pehala mentioned this pull request Jul 11, 2022
Merged
jsmolar
jsmolar reviewed Jul 14, 2022
View reviewed changes
testsuite/certificates/__init__.py Outdated Show resolved Hide resolved
testsuite/certificates/__init__.py Outdated Show resolved Hide resolved
jsmolar
jsmolar reviewed Jul 14, 2022
View reviewed changes
testsuite/certificates/__init__.py Outdated Show resolved Hide resolved
testsuite/certificates/__init__.py Show resolved Hide resolved
@pehala pehala force-pushed the tls branch 3 times, most recently from 1d03b4c to 2ca28d5 Compare August 1, 2022 13:58
@pehala pehala requested review from jsmolar, azgabur and jakurban August 1, 2022 13:59
@pehala pehala mentioned this pull request Aug 1, 2022
Merged
@pehala pehala force-pushed the tls branch 2 times, most recently from cbbb238 to 56edaca Compare August 4, 2022 11:19
@pehala pehala merged commit e2aa342 into Kuadrant:main Aug 8, 2022
mkudlej
mkudlej reviewed Aug 9, 2022
View reviewed changes
Copy link
Contributor

@mkudlej mkudlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkudlej mkudlej mkudlej left review comments

@jsmolar jsmolar jsmolar approved these changes

@azgabur azgabur Awaiting requested review from azgabur

@jakurban jakurban Awaiting requested review from jakurban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Authorino behind TLS envoy test
3 participants
@pehala @mkudlej @jsmolar