Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kuadrants AuthPolicy #158

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Jan 6, 2023

Overview

This PR adds the ability to run (most of) the authoring tests on Kuadrant. The actual tests are mostly unchanged, but everything else had to change in some mostly minor ways. Currently, around 43 out of 106 tests run on Kuadrant, and many need code changes that will come in subsequent PRs.

Notable changes

  • Add Route and Proxy interfaces
    • Kuadrant uses a different route and differently configured envoy than we do, so I added these interfaces to ensure compatibility with new Kuadrant classes.
    • Change some parameter types in said classes to ensure compatibility with the new ones.
  • Add run_on_kuadrant fixture, which indicates that the test or module doesn't run on Kuadrant
  • Add configuration options for Kuadrant deployment
    • It expects that Kuadrant and Gateway are already deployed.

pehala added 2 commits January 6, 2023 10:20
- Replaces direct Envoy and OpenShift Route handling
- Add OpenshiftRoute and Envoy as implementation
- Allow multiple hostnames per Route
config/settings.local.yaml.tpl Outdated Show resolved Hide resolved
config/settings.yaml Show resolved Hide resolved
Copy link
Contributor

@jsmolar jsmolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capabilities should be solved in another PR, right now I'm fine with a solution that leverages fixtures (#164)

testsuite/openshift/objects/auth_config/auth_policy.py Outdated Show resolved Hide resolved
testsuite/openshift/objects/gateway_api/__init__.py Outdated Show resolved Hide resolved
testsuite/tests/kuadrant/conftest.py Outdated Show resolved Hide resolved
testsuite/openshift/envoy.py Show resolved Hide resolved
testsuite/openshift/envoy.py Show resolved Hide resolved
@pehala pehala merged commit c8271a1 into Kuadrant:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants