Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running on already deployed Authorino #12

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Jun 22, 2022

  • The operator test will be skipped if that's the case.
  • You can set it up by settings authorino.deploy to false
    • You also need to specify the authorization URL for it through authorino.url
    • Details can be found in settings.local.yamp.tpl

self._authorization_url = authorization_url

def wait_for_ready(self):
return True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we don't care if the preexisting Authorino instance is NOT ready, right? Tests will fail of course, but that's all right. Any preexisting Authorino instance is supposed to be ready before using this option, I imagine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, and even if we wanted we cannot assume that we have permission to view the status of it, it might be located in a completely different namespace.

@pehala pehala merged commit 998063c into Kuadrant:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants