SIGSEGV on generating resources with a spec without x-kuadrant extensions #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
requested changes
Apr 29, 2024
jasonmadigan
force-pushed
the
64-sigsegv-fix
branch
from
2251a35 to
f683cab
Compare
|
thanks @eguzki - patched up |
eguzki
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix to resolve a small bug:
#64
We could make this more complex by detecting the many permutations of inclusion of
x-kuadrantextensions in specs, to warn/panic if none are found. That may be a better fix longer term (could be addressed this way as a follow-on PR if needs be - this gets us out of a hole right now).Verifying
# With kuadrantctl 0.2.0 kuadrantctl generate kuadrant authpolicy --oas ./examples/oas3/petstore.yaml=>
With this patch, no panic.
Have also patched
HTTPRouteGatewayParentRefsFromOASandHTTPRouteHostnamesFromOASwhich have a similar bug.