add perms and docs for azure #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: craig <[email protected]>
mikenairn
reviewed
Sep 18, 2024
| } | ||
| ] | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Presumably after we drop support for provider health checks we won't really need those HealthCheck permissions? Should we keep them?
There was a problem hiding this comment.
I will add a note to the health check epic to update the needed perms
mikenairn
reviewed
Sep 18, 2024
| @@ -53,6 +102,74 @@ kubectl create secret generic my-test-gcp-credentials \ | |||
|
|
|||
|
|
|||
| #### Google Cloud DNS Access permissions required | |||
| See: | |||
|
|
|||
| We have tested with the `dns.admin` role. See for more details: | |||
|
|
|||
| [https://cloud.google.com/dns/docs/access-control#dns.admin](https://cloud.google.com/dns/docs/access-control#dns.admin) | |||
There was a problem hiding this comment.
Is it possible with GCP to setup more fine grained permissions on a credential, limit the zones we have access to etc...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds specific perms needed for Azure and AWS