[feature] Add simple Azure provider behind feature flag #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbrookes
force-pushed
the
gh-12
branch
5 times, most recently
from
fc58508
to
da3cb35
Compare
mikenairn
reviewed
Jul 10, 2024
philbrookes
force-pushed
the
gh-12
branch
2 times, most recently
from
b728106
to
b2c39f7
Compare
mikenairn
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Left some comments.
Can you add "azure" here so that it gets enabled on the local deployments (make local-setup(-multi) DEPLOY=true)
value: --provider=aws,google,azure,inmemory
Can you also add the azure import here, and add a skip on the loadbalanced test in there also.
_ "github.com/kuadrant/dns-operator/internal/provider/azure"
Are you adding azure to the GH action e2e tests in this PR or doing that in another? Probably good to add it sooner rather than later, will require a new dns zone and principal etc.. setup in Azure and credentials added in GitHub.
config/local-setup/managedzone/azure/azure-credentials.env.template
Outdated
Show resolved
Hide resolved
config/local-setup/managedzone/azure/managed-zone-config.env.template
Outdated
Show resolved
Hide resolved
philbrookes
force-pushed
the
gh-12
branch
3 times, most recently
from
772dcf0
to
5c4d988
Compare
mikenairn
reviewed
Jul 12, 2024
philbrookes
force-pushed
the
gh-12
branch
2 times, most recently
from
9f69bf7
to
1c968a3
Compare
philbrookes
changed the title
mikenairn
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.