Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump OpenTelemetry Schema URL to 1.21.0 #455

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

guicassolato
Copy link
Collaborator

Fixes an error in the initialization of Authorino when tracing services are enabled.

Error message:

cannot merge resource due to conflicting Schema URL

Stacktrace:

main.setupTelemetryServices
	/usr/src/authorino/main.go:409
main.setup
	/usr/src/authorino/main.go:387
main.runAuthorizationServer
	/usr/src/authorino/main.go:225
github.com/spf13/cobra.(*Command).execute
	/opt/app-root/src/go/pkg/mod/github.com/spf13/[email protected]/command.go:944
github.com/spf13/cobra.(*Command).ExecuteC
	/opt/app-root/src/go/pkg/mod/github.com/spf13/[email protected]/command.go:1068
github.com/spf13/cobra.(*Command).Execute
	/opt/app-root/src/go/pkg/mod/github.com/spf13/[email protected]/command.go:992
github.com/spf13/cobra.(*Command).ExecuteContext
	/opt/app-root/src/go/pkg/mod/github.com/spf13/[email protected]/command.go:985
main.main
	/usr/src/authorino/main.go:149
runtime.main
	/usr/lib/golang/src/runtime/proc.go:250

This was likely caused after upgrading otel deps to v0.46.x (#448) and it's a known issue of otel's Resource API: open-telemetry/opentelemetry-go#2341.

Fixes an error in the initialization of Authorino with tracing services enabled – "cannot merge resource due to conflicting Schema URL"
@guicassolato guicassolato self-assigned this Jan 19, 2024
@guicassolato guicassolato added kind/bug Something isn't working area/dependencies Pull requests that update a dependency file size/small labels Jan 19, 2024
@guicassolato guicassolato requested a review from a team January 19, 2024 13:53
Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build image locally and image worked with on Kuadrant/kuadrant-operator#393
/lgtm

@guicassolato guicassolato added this to the v0.17.x milestone Jan 22, 2024
@guicassolato guicassolato merged commit c4dfd4f into main Jan 22, 2024
11 checks passed
@guicassolato guicassolato deleted the fix-otel-semconv branch January 22, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/bug Something isn't working size/small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants