Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version commit hash #209

Merged
merged 1 commit into from
Sep 17, 2024
Merged

version commit hash #209

merged 1 commit into from
Sep 17, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Sep 16, 2024

What

Generates log line with traceable version for custom builds as well as relese builds. Consistent with other kuadrant components.

{"level":"info","ts":"2024-09-16T17:32:47+02:00","logger":"authorino-operator.controller.Authorino.setup","msg":"booting up authorino operator","version":"012ee63c42d573ea6c08b3895ab3709ed052a25f","commit":"012ee63c42d573ea6c08b3895ab3709ed052a25f","dirty":"true","default authorino image":"quay.io/kuadrant/authorino:latest"}

This PR does not change the value of `version

Attribute Description
version Same as before. This PR does not change the value. For custom builds: git sha, for releases: release number vX.Y.Z
commit git sha
dirty true when not git committed files used in the build

For releases, the VERSION attributes provides high level overview of the release number. Useful to determine included features. The COMMIT attribute provides git reference. Useful for engineering reporting.

Verification Steps

  • Run local k8s cluster
  • make install
  • make run

You should see a log line like above

PS: Where is the "make local-setup" so useful and available in all kuadrant operators?

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.78%. Comparing base (012ee63) to head (a3ab60a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files           2        2           
  Lines         785      785           
=======================================
  Hits          485      485           
  Misses        249      249           
  Partials       51       51           
Flag Coverage Δ
unit 61.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔎

Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
@eguzki eguzki force-pushed the version-commit-hash branch from 609fa06 to a3ab60a Compare September 17, 2024 07:44
@eguzki eguzki merged commit 66c85ed into main Sep 17, 2024
11 checks passed
@eguzki eguzki deleted the version-commit-hash branch September 17, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants