Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Some Useless Codes #36

Merged

Conversation

aquarius-kuchain
Copy link
Contributor

@aquarius-kuchain aquarius-kuchain commented Aug 27, 2020

Summary

Del some useless code.

Modifys

  • del protobuf:"XXX" tag in structs
  • del useless msg def
  • fix test error by api change

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch
  • Linked to Github issue with discussion.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aquarius-kuchain aquarius-kuchain added the bug Something isn't working label Aug 27, 2020
@aquarius-kuchain aquarius-kuchain self-assigned this Aug 27, 2020
@aquarius-kuchain aquarius-kuchain merged commit 68517cf into KuChainNetwork:develop Aug 27, 2020
@aquarius-kuchain aquarius-kuchain deleted the features/msg-actions branch August 27, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant