refactor market + remove code #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Sep 22, 2023
agoric/contract/src/kreadKit.js
Outdated
| @@ -1055,15 +1079,21 @@ export const prepareKreadKit = async ( | |||
| const platformFee = multiplyBy(want.Price, platformFeeRate); | |||
|
|
|||
| const object = objectInSellSeat.value.payload[0][0]; | |||
| const id = this.state.market.metrics.get('item').putForSaleAmount; | |||
There was a problem hiding this comment.
"amount" is a formal term in ERTP.
please rename to something about how this is is a serial counter. Also consider making clear that it's to be incremented at the end (that it's the count of items that have already been successfully listed for sale).
agoric/contract/src/kreadKit.js
Outdated
| const claimedIdAndRecorder = await Promise.all( | ||
| itemsToSell.map(async (copyBagEntry) => { | ||
| const [_, itemSupply] = copyBagEntry; | ||
| const array = Array.from(Array(Number(itemSupply)).keys()); |
There was a problem hiding this comment.
Suggested change
| const array = Array.from(Array(Number(itemSupply)).keys()); | |
| const itemIds = Array.from(Array(Number(itemSupply)).keys()); |
agoric/contract/src/kreadKit.js
Outdated
| const [itemObject, itemSupply] = copyBagEntry; | ||
|
|
||
| for (let n = 0; n < itemSupply; n++) { | ||
| const [id, entryRecorder] = claimedIdAndRecorder.flat()[count]; |
There was a problem hiding this comment.
I'm confused why you need to flatten. You have nested loops over nested arrays.
Consider just iterating over the inner array in this inner loop
agoric/contract/src/kreadKit.js
Outdated
| @@ -1198,6 +1253,9 @@ export const prepareKreadKit = async ( | |||
|
|
|||
| const object = objectInSellSeat.value.payload[0][0]; | |||
|
|
|||
| const entryRecorder = | |||
| await marketFacet.makeMarketCharacterRecorderKit(object.name); | |||
There was a problem hiding this comment.
"object" is a type for almost anything in JS.
Suggested change
| await marketFacet.makeMarketCharacterRecorderKit(object.name); | |
| await marketFacet.makeMarketCharacterRecorderKit(item.name); |
turadg
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor market storage node utilisation to use nested children and remove nodes after buying or offer exit
closes : #17