Issue hashicorp#7: Fix error in renewperiodic logic

KrolikROJER · May 27, 2015 · 65b819d · 65b819d
1 parent 26c7732
commit 65b819d
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/Consul.Test/SemaphoreTest.cs b/Consul.Test/SemaphoreTest.cs
@@ -112,6 +112,29 @@ public void Semaphore_AcquireRelease()
             Assert.IsFalse(s.IsHeld);
         }
 
+        [TestMethod]
+        public void Semaphore_AcquireWaitRelease()
+        {
+            const string Name = "XService";
+            const string Prefix = Name + "/lock";
+            const int Limit = 1;
+            var _semaphoreOptions = new SemaphoreOptions(Prefix, Limit) { SessionName = Name + "_Session", SessionTTL = TimeSpan.FromSeconds(10) };
+            var c = ClientTest.MakeClient();
+
+            var s = c.Semaphore(_semaphoreOptions);
+
+            s.Acquire(CancellationToken.None);
+
+            Assert.IsTrue(s.IsHeld);
+            Thread.Sleep(30000);
+            Assert.IsTrue(s.IsHeld);
+
+            Assert.IsTrue(s.IsHeld);
+
+            s.Release();
+
+            Assert.IsFalse(s.IsHeld);
+        }
 
         [TestMethod]
         public void Semaphore_Contend()

diff --git a/Consul/Session.cs b/Consul/Session.cs
@@ -325,7 +325,7 @@ public Task RenewPeriodic(TimeSpan initialTTL, string id, WriteOptions q, Cancel
                         try
                         {
                             var res = Renew(id, q);
-                            if (res.Response != null)
+                            if (res.Response == null)
                             {
                                 lastException = new TaskCanceledException("Session no longer exists");
                             }