Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Removed two redundant default values for "reset_displacements" #13028

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

avdg81
Copy link
Contributor

@avdg81 avdg81 commented Jan 22, 2025

📝 Description

Two Python solvers (PwSolver and UPwSolver) defined default values for "reset_displacements" that was already defined by their base class (GeoMechanicalSolver). These repeated default values have been removed now.

@avdg81 avdg81 added Cleanup GeoMechanics Issues related to the GeoMechanicsApplication labels Jan 22, 2025
@avdg81 avdg81 requested a review from WPK4FEM January 22, 2025 16:11
@avdg81 avdg81 self-assigned this Jan 22, 2025
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant, indeed please remove.

@avdg81 avdg81 merged commit 3be55ed into master Jan 23, 2025
11 checks passed
@avdg81 avdg81 deleted the geo/remove-two-redundant-defaults branch January 23, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup GeoMechanics Issues related to the GeoMechanicsApplication
Development

Successfully merging this pull request may close these issues.

2 participants