Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEMApplication] New linear contact force model #13008

Merged
merged 10 commits into from
Jan 19, 2025
Merged

Conversation

rlrangel
Copy link
Contributor

Adding a new simple linear force model, which I have recently used in a research.

@rlrangel rlrangel requested a review from a team as a code owner January 14, 2025 08:20
@rlrangel rlrangel requested review from AlejandroCornejo and ChengshunShang1996 and removed request for a team January 14, 2025 08:20
@AlejandroCornejo
Copy link
Member

one question, don't you add any test for the future?

const double my_poisson = element->GetPoisson();

mKn = my_young * my_radius; // normal
mKt = my_poisson * mKn; // tangent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Rafael. In this line, you are calculating the tangential stiffness using the "poisson_ratio" from the particle. However, in both of your papers, you were using the item "tangential-to-normal stiffness ratio". To me, the physical significance of those two items is different.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zhao actually calls it the Poison ration. I decided to call it tangential-to-normal stiffness ratio in my papers exactly because it has a different physical meaning.

// References using this model:
// R.L. Rangel et al. (2024). Multiscale data-driven modeling of the thermomechanical behavior of granular media with thermal expansion effects. Comput Geotech, 176:106789.
// R.L. Rangel et al. (2024). A continuum--discrete multiscale methodology using machine learning for thermal analysis of granular media. Comput Geotech, 168:106118.
// S. Zhao et al. (2020). Multiscale modeling of thermo-mechanical responses of granular materials: A hierarchical continuum--discrete coupling approach. CMAME, 367:113100.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the paper by Zhao, although they said that the simple linear contact model was used, they did not explicitly give the formulation about how to calculate the normal and tangential stiffness. Should this one be replaced with another piece of literature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. I changed the reference.

CalculateTangentialForceWithNeighbour(normal_contact_force, OldLocalElasticContactForce, LocalElasticContactForce, LocalDeltDisp, sliding, element, wall);
}

template<class NeighbourClassType>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A template function is suggested to be put in the head file if I am right. Please look at this link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. Done it.

@rlrangel
Copy link
Contributor Author

one question, don't you add any test for the future?

I decided to make another PR later exclusively dedicated to adding tests.

Copy link
Member

@ChengshunShang1996 ChengshunShang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice done

@rlrangel rlrangel merged commit c14fb45 into master Jan 19, 2025
11 checks passed
@rlrangel rlrangel deleted the dem-new-force-model branch January 19, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants