[GeoMechanicsApplication] Fix some minor issues #13005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some inconsistencies between function parameter names used in header files and those used in implementation files.
- Marked it `[[nodiscard]]`. - Made it `static`. - Don't repeat the return type; use a braced-initializer list instead.
This fixes an inconsistency between a function parameter name used in the header file and the one used in the implementation file.
WPK4FEM
previously approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Hi Anne,
This comprosises:
1 rename GPoint or PointNumber to IntegrationPointIndex
2 marking some functions as nodiscard
3 more straightforward returnvalue for NewmarkQuasistaticUPwScheme ( as I recon its type is already known )
That looks o.k. to me. I have only looked at the changes, not at the surrounding lines of code.
Regards, Wijtze Pieter
WPK4FEM
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Addressed a few minor issues found by Clang-tidy:
[[nodiscard]]attribute to a member function.