Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New windows base image #10037

Closed
wants to merge 7 commits into from
Closed

New windows base image #10037

wants to merge 7 commits into from

Conversation

roigcarlo
Copy link
Member

📝 Description
A new base image that include boost + pip dependencies so we don't have to download them every time. That should prevent most of the latest error about "boost cannot be downloaded" because Sourceforge...

Also I split the current docker build workflows and created a new one so only the proper image get re-built when changes happen.

🆕 Changelog

  • Added new default windows building env.
  • Split the build workflows for ubuntu and centos
  • Added new workflow to build win

@roigcarlo roigcarlo requested a review from loumalouomega July 15, 2022 14:13
@roigcarlo roigcarlo requested a review from a team as a code owner July 15, 2022 14:13
@@ -0,0 +1,35 @@
name: Build Docker Images for CI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Centos, is the title wrong?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, as I said a also updated the other workflows

Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay (title looks confusing, I see things not Windows related)

@roigcarlo
Copy link
Member Author

Nice but we cannot merge because of actions/runner#904. 😢

@roigcarlo roigcarlo closed this Jul 15, 2022
@roigcarlo roigcarlo deleted the ci/new-windows-base branch March 14, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants